Skip to content

Conversation

@tyxla
Copy link
Member

@tyxla tyxla commented Aug 13, 2024

What?

Fix a typo we introduced in #64459.

Why?

Just fixing a typo.

Right now we can see a warning:

Warning: Undefined variable $parts_key in /var/www/html/wp-content/plugins/gutenberg/lib/compat/wordpress-6.7/rest-api.php on line 42

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/wp-content/plugins/gutenberg/lib/compat/wordpress-6.7/rest-api.php:42) in /var/www/html/wp-admin/admin-header.php on line 9

How?

Using the right variable name.

Testing Instructions

  • Load the post editor.
  • Verify you don't see a warning.

Testing Instructions for Keyboard

None

Screenshots or screencast

None

@tyxla tyxla added [Type] Regression Related to a regression in the latest release [Package] Edit Post /packages/edit-post labels Aug 13, 2024
@tyxla tyxla requested review from a team and Mamaduka August 13, 2024 14:59
@tyxla tyxla self-assigned this Aug 13, 2024
@tyxla tyxla requested a review from spacedmonkey as a code owner August 13, 2024 14:59
@github-actions
Copy link

github-actions bot commented Aug 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @tyxla!

@tyxla tyxla enabled auto-merge (squash) August 13, 2024 15:22
@tyxla tyxla merged commit b3ce94e into trunk Aug 13, 2024
@tyxla tyxla deleted the fix/reusable-block-preload branch August 13, 2024 15:40
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 13, 2024
getdave pushed a commit that referenced this pull request Aug 14, 2024
* Edit Post: Fix user pattern preloading filter

* Backport changelog

Co-authored-by: tyxla <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Edit Post /packages/edit-post [Type] Regression Related to a regression in the latest release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants